Skip to content

Don’t render disabled links in pagination #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pepelsbey
Copy link
Member

@pepelsbey pepelsbey commented May 28, 2025

Description

Disabling interactive elements is not a good idea: they are still focusable and very confusing for screen readers. It’s better not to render them at all or render something inert instead. I’d suggest the simplest solution: render nothing.

Note

Also, linter gives me the following error on line 148:

This attribute binds the type 'DirectiveResult<{ prototype: any; directiveName: string; resultType: number; new(partInfo: ChildPartInfo | AttributePartInfo | ElementPartInfo) => UnsafeHTMLDirective; }> | undefined' which can end up binding the string 'undefined'. Use the 'ifDefined' directive?

@pepelsbey pepelsbey requested a review from fiji-flo May 28, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant